bug(refs T34956): Fix stickier position #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't stick to direction if there is not enough place for the element.
Don't stick to direction if there is not enough place for the element.
spiess-demos
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
I'd follow your proposal to revert the other fix. @sakutademos would you agree here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://yaits.demos-deutschland.de/T34956
If the element ends below context the position should be the bottom of context. Otherwise the element has not enough space and is not reachable. Don't stick to direction in this case.
It seems like the bug was introduced with this fix #438
Since this doesn't fix the bug completely (see https://yaits.demos-deutschland.de/T34173) I suggest to revert it and to try to fix it another way.