Fix(T33788): display only unique fields in the error message #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue fields. However it does not work correctly with demosplan core, use filter() function instead
salisdemos
requested changes
Nov 9, 2023
| const nonEmptyFieldNames = validatedForm.invalidFields | ||
| .map(field => field.getAttribute('data-dp-validate-error-fieldname')) | ||
| .filter(Boolean) | ||
| const nonEmptyUniqueFieldNames = nonEmptyFieldNames.filter((field, idx) => nonEmptyFieldNames.indexOf(field) === idx) |
There was a problem hiding this comment.
thx, done here 8847423
Comment on lines
50
to
53
| const nonEmptyFieldNames = validatedForm.invalidFields | ||
| .map(field => field.getAttribute('data-dp-validate-error-fieldname')) | ||
| .filter(Boolean) | ||
| const nonEmptyUniqueFieldNames = nonEmptyFieldNames.filter((field, idx) => nonEmptyFieldNames.indexOf(field) === idx) |
There was a problem hiding this comment.
I think we can extract that to an own small method since the exact same Code is used twice.
There was a problem hiding this comment.
would it be also ok? --> 8847423#diff-fdc53ff4f95d479db51dcfdf0f2706e9b4974251ed0b258d11a27da73051073bR53
There was a problem hiding this comment.
It looks like. Although I wonder why sonarcloud is not complaining...
Co-authored-by: salisdemos <40487461+salisdemos@users.noreply.github.com>
…variable directly, remove an extra variable
salisdemos
approved these changes
Nov 9, 2023
sakutademos
deleted the
b_T33137_accessible_notifications_new_set_issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://yaits.demos-deutschland.de/T33137 --> 1.PLZ wird 2x angezeigt (nur beim Feld PLZ tritt der Fehler auf
Description: This PR fixes the issue with incorrect field names in the error message: [object Set]
JavaScript
Setwas used for storing a collection of unique fields. However it does not work correctly after installing a new version of demosplan-ui in demosplan core..