lock style-dictionary at 3.8.0 #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style-dictionary 3.9 causes the tokens build to output invalid scss. See amzn/style-dictionary#1037
salisdemos
approved these changes
Dec 8, 2023
# Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style-dictionary 3.9 causes the tokens build to output invalid scss. while i cannot rule out that the error may be related to how we are using style-dictionary, i was not able to resolve the issue immediately. In the meantime i'd suggest to lock style-dictionary at v3.8.0.
See amzn/style-dictionary#1037