Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send uppercase request headers in DpApi #706

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

spiess-demos
Copy link
Contributor

Whether it is required by spec is debated, especially when it comes to http2, but as the vuex-json-api plugin also sends headers in the format of "First-Char-Uppercase", this is done here, too, for the time being.

whether it is required by spec is debated, especially
when it comes to http2, but as the vuex-json-api plugin
also sends headers in the format of "First-Char-Uppercase",
this is done here, too, for the time being.
Copy link
Contributor

@hwiem hwiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! (code review only)

@spiess-demos spiess-demos merged commit 9fbfff1 into main Jan 9, 2024
1 check passed
@spiess-demos spiess-demos deleted the f_uppercase_headers branch January 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants