chore: send csrf token when submitting a rpc2.0 call #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2024 17:05
- mainly to prevent the purple error messages about missing csrf tokens when loading addons
mussbach
reviewed
Jan 17, 2024
src/lib/DpApi.js
Outdated
| } | ||
| } | ||
|
|
||
| const apiDefaultHeaders = { | ||
| 'X-JWT-Authorization': 'Bearer ' + jwtToken | ||
| 'X-JWT-Authorization': 'Bearer ' + jwtToken, | ||
| 'X-Csrf-Token': csrfToken |
There was a problem hiding this comment.
better use small caps like x-csrf-token for new headers as they should be only small chars in http2
There was a problem hiding this comment.
ah thanks, indeed i remember the slack discussion. done here 6432cf4
| } | ||
| } | ||
|
|
||
| const apiDefaultHeaders = { | ||
| 'X-JWT-Authorization': 'Bearer ' + jwtToken | ||
| 'X-JWT-Authorization': 'Bearer ' + jwtToken, | ||
| 'x-csrf-token': csrfToken |
There was a problem hiding this comment.
why is the new header only added to apiDefaultHeaders, not api2defaultHeaders (which is used on all 2.0 routes)?
| @@ -4,6 +4,10 @@ Since v0.0.10, this Changelog is formatted according to the [Common Changelog][c | |||
|
|
|||
| ## UNRELEASED | |||
|
|
|||
| ### Added | |||
|
|
|||
| - ([#714](https://github.com/demos-europe/demosplan-ui/pull/714/files)) add csrf token to dpRpc to prevent missing csrf errors ([@muellerdemos](https://github.com/muellerdemos)) | |||
There was a problem hiding this comment.
in fact this adds the headers to both dpApi and dpRpc calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked PRs:
demos-europe/demosplan-core#2586
Important:
Before removing the hidden input field throughout dplan this PR needs to be merged first and a new release is needed