fix(DPLAN-2231): fix 'data-dp-validate-if' within a fieldset #850
Conversation
… expected when a fieldset is provided instead of a form, so check additionally if a fieldset provided, reduce cognitive complexity for the assignHandlersForSingleInput method
| @@ -21,7 +21,8 @@ function assignHandlersForSingleInput (input) { | |||
| allConditions.forEach(condition => { | |||
| const comparisonType = condition.indexOf('!==') > -1 ? 'isNotEqual' : 'isEqual' | |||
| const matchers = condition.split(comparisonType === 'isNotEqual' ? '!==' : '===') | |||
| const form = input.closest('[data-dp-validate]') | |||
| const validationContainer = input.closest('[data-dp-validate]') | |||
| const form = validationContainer.tagName === 'FIELDSET' && validationContainer.form ? validationContainer.form : validationContainer | |||
There was a problem hiding this comment.
I feel this logic needs a little commenting.
Also, i think we should move the dp-validate documentation from demosplan-core into demosplan-ui and check if it is outdated (certainly not in this PR).
There was a problem hiding this comment.
add a comment here ae879da
There was a problem hiding this comment.
We currently have a Storybook in demosplan-ui. What do you mean by move it into demosplan-ui? create a docu for demosplan-ui?
There was a problem hiding this comment.
Correct. At the moment we document only components and tokens via Storybook. Neither "directives", "lib" (which is highly unsorted and should be sorted upfront), "mixins" or "utils" are documented at all. At a second glance i think we should at first decide how to structure util/lib code within demosplan-ui, and only after that document things we decided to be "multi purpose enough" to stay in demosplan-ui.
There was a problem hiding this comment.
I agree that an explanatory comment would be helpful (what @spiess-demos said).
Code lgtm, just a comment on the changelog entry
…-with-the-fieldset' into fix-DPLAN-2231-validate-if-issue-with-the-fieldset # Conflicts: # CHANGELOG.md
sakutademos
deleted the
fix-DPLAN-2231-validate-if-issue-with-the-fieldset
branch
Ticket: DPLAN-2231
Description: This PR fixes an issue with validation when a 'data-dp-validate-if' attribute is provided in an input within a fieldset instead of directly within a form, because the query selector (line 20) should search the entire form rather than just the fieldset; otherwise, it returns null.
fieldsetis provided instead of aformwhen usinginput.closest('[data-dp-validate]')