chore (refs DPLAN-11668): Add missing Hooks for E-2-E Test. #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salisdemos
requested changes
May 29, 2024
| @@ -3,6 +3,7 @@ | |||
| <button | |||
| v-for="(step, idx) in steps" | |||
| :key="`step_${idx}`" | |||
| :data-cy="`${dataCy}:${idx}`" | |||
There was a problem hiding this comment.
Suggested change
| :data-cy="`${dataCy}:${idx}`" | |
| :data-cy="`${dataCy}:${step.label}`" |
There was a problem hiding this comment.
With this change we have now hooks like: data-cy="multistepNav:Ihre Stellungnahme" with space.
Can I make it like :data-cy="${dataCy}:${step.label.replace(/\s+/g, '-').toLowerCase()}"?
Then Hook data-cy="multistepNav:ihre-stellungnahme"
There was a problem hiding this comment.
Ok. Sorry. Thought the label would look more like a key. than we better stick to the idx.
salisdemos
requested changes
May 29, 2024
| @@ -3,6 +3,7 @@ | |||
| <button | |||
| v-for="(step, idx) in steps" | |||
| :key="`step_${idx}`" | |||
| :data-cy="`${dataCy}:${idx}`" | |||
There was a problem hiding this comment.
Ok. Sorry. Thought the label would look more like a key. than we better stick to the idx.
salisdemos
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://demoseurope.youtrack.cloud/issue/DPLAN-11668/Hooks-Public-View-Hooks