Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F t31116 demosplan UI no longer use routing #91
F t31116 demosplan UI no longer use routing #91
Changes from 12 commits
ff4de38
d7329b8
bb3ff53
a6b53e3
395a417
25f8d2a
cab5e33
1095c03
f3a4e1a
c855277
104e2b5
6f5b8b1
ad1afe6
b6404ac
0b6cba1
98fdabd
ca229db
1c4e829
d7d1be9
54d9444
3784acc
4c17057
2783e7d
5855c9d
f998847
551eeab
3a51670
462e0e5
1bb59b6
7fb3fad
82e69ec
ed7308b
d20932a
9fcdfbc
cd139e8
ecb50ce
9c74850
8f7bf80
031f9e6
39b6d09
db654ec
391f33b
57ffba6
e96471b
61dec86
5873380
3f86088
8c7cfab
829f74b
a4221b3
31890c2
b0db63b
2b50a4c
fc401f5
8d194ed
4e4acde
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to pass the complete route - the result of Routing.generate - not just the String that has to be generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See:
#91 (comment)
#91 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above and all other changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See:
#91 (comment)
#91 (comment)