-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore installability of package #983
Conversation
Due to several things, the yarn.lock and package.json were out of sync, so that vue-loader was not installed anymore by yarn 1 and the build failed consequently. This change restores the state of the package.json before bumping Yarn to 4, and it additionally removes "@webpack-cli/generators" which seems to be a remnant of bootstrapping the project build. Also, this change bumps several dependencies to their latest resolvable minor versions as i deleted yarn.lock before running `yarn install` to have a clean start, again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run yarn build
(after running yarn
), I get the string-width error and need to run yarn upgrade jest
to make it work. This results in an updated yarn.lock
. Should that be commited?
i got the string-width error, too. but sadly, after running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm + works, thanks ❤️
Due to several things, the yarn.lock and package.json were out of sync, so that vue-loader was not installed anymore by yarn 1 and the build failed consequently.
This change restores the state of the package.json before bumping Yarn to 4, and it additionally removes "@webpack-cli/generators" which seems to be a remnant of bootstrapping the project build.
Also, this change bumps several dependencies to their latest resolvable minor versions as i deleted yarn.lock before running
yarn install
to have a clean start, again.Also, this change defines resolutions for
string-width
andwrap-ansi
to fix the string-width-error, again. See this comment for an explanation.