Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add svd gradient #58

Merged
merged 1 commit into from
Mar 18, 2018
Merged

add svd gradient #58

merged 1 commit into from
Mar 18, 2018

Conversation

CarloLucibello
Copy link
Collaborator

x-ref #45

kirnap
kirnap approved these changes Mar 4, 2018
View reviewed changes
Copy link

@kirnap kirnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • KnetArray Implementation is missing.
  • Testing is not implemented using addtest(:svd, inputs...) function.
    Other than that, everything is ok.

@denizyuret denizyuret merged commit 2dea04a into denizyuret:master Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirnap kirnap kirnap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarloLucibello @kirnap @denizyuret