Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract rules into separate Markdown files #196

Merged

Conversation

julianbartel
Copy link
Contributor

@julianbartel julianbartel commented Oct 20, 2019

Extract rules into separate Markdown files to support individual Frontmatter per rule.

  • PowerShell script for building static HTML (PDF) must be extended
  • Take rule prefixes from variable in cheat sheet

@julianbartel
Copy link
Contributor Author

Marked as draft because I would like to clarify a few things (see file comments).
One general point: I thought about removing the AV prefix in rule identifiers, so it could be tailored in forks without need to change every file.

@dennisdoomen
Copy link
Owner

I thought about removing the AV prefix in rule identifiers, so it could be tailored in forks without need to change every file.

I've used that prefix for the last 15 years, so I'd like to keep it. But maybe we make it a variable?

@julianbartel
Copy link
Contributor Author

I've used that prefix for the last 15 years, so I'd like to keep it. But maybe we make it a variable?

That's how I meant it. ;-)
I would have done it by simply remove the prefix from the IDs and put it into the template. But a variable is more precise. Just need some time to work that out as Jekyll is new to me.

@dennisdoomen
Copy link
Owner

Just need some time to work that out as Jekyll is new to me.

I think you can put that variable, e.g. rulePrefix, in the _config.yml and then access it through {{ site.rulePrefix }}.

@julianbartel julianbartel changed the title Basic separation of rules Extract rules into separate Markdown files (#194) Oct 22, 2019
@julianbartel julianbartel changed the title Extract rules into separate Markdown files (#194) Extract rules into separate Markdown files Oct 22, 2019
@julianbartel julianbartel marked this pull request as ready for review October 27, 2019 10:08
Copy link
Owner

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Search is no longer working
  • The recent look-and-feel changes somehow are not available in your PR.

@julianbartel julianbartel force-pushed the feature/rule-separation branch from e8b353c to f332d42 Compare November 17, 2019 12:16
@julianbartel
Copy link
Contributor Author

julianbartel commented Nov 17, 2019

Search is no longer working

Added rules to the search data store.

The recent look-and-feel changes somehow are not available in your PR.

Rebased PR on master. Hope this did not mess up the PR or review state, but seems to work.

@dennisdoomen
Copy link
Owner

Wow. This really starts to look great. I found another bug though. I'm not sure it's my local environment, bit if you search for av12, you can't open any of the results.

@julianbartel
Copy link
Contributor Author

Wow. This really starts to look great. I found another bug though. I'm not sure it's my local environment, bit if you search for av12, you can't open any of the results.

Can you specify this a bit? I made a clean checkout and rebuild to check it out, but search seems to work as expected in my workspace (see screen cap). 🤔

search-sample

@dennisdoomen dennisdoomen merged commit cdf8dde into dennisdoomen:master Nov 21, 2019
@dennisdoomen
Copy link
Owner

@julianbartel awesome work man. It does work as expected. It must have been my machine.

@dennisdoomen
Copy link
Owner

Hmm, just discovered that the "Edit page" button at the top of each page no longer works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants