Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV2201 static member access #223

Merged
merged 1 commit into from
Mar 6, 2021
Merged

AV2201 static member access #223

merged 1 commit into from
Mar 6, 2021

Conversation

bkoelman
Copy link
Contributor

@bkoelman bkoelman commented Mar 6, 2021

Fixes #218.

@bkoelman
Copy link
Contributor Author

bkoelman commented Mar 6, 2021

Side note: I see that 'develop' is the default branch, while all recent changes have been done in master (it is 41 commits ahead). I remember from the past you liked to use GitFlow, but to me it only adds confusion. When I go to the repo, it shows me an outdated version. Given there's limited changes in this repo, wouldn't it be easier to just have a single master branch without develop?

@dennisdoomen
Copy link
Owner

Side note: I see that 'develop' is the default branch, while all recent changes have been done in master (it is 41 commits ahead). I remember from the past you liked to use GitFlow, but to me it only adds confusion. When I go to the repo, it shows me an outdated version. Given there's limited changes in this repo, wouldn't it be easier to just have a single master branch without develop?

Yeah, you might be right. I was trying to make breaking changes explicit by using semantic versioning.

@dennisdoomen
Copy link
Owner

But this PR is kind of a breaking change since it is the opposite of what we said before. How should we deal with that?

@bart-degreed
Copy link
Contributor

Except for spelling corrections, changes to the website generation process and rendered layout, all textual changes are breaking. Adding a new rule breaks all codebases that didn't utilize that rule before. The same for adding an exception to an existing rule. I find the concept of semantic versioning and whether changes are considered breaking of limited use in this repo, because it does not affect binary dependencies. Likewise it makes no sense to deprecate a rule to remove it in the next major version, because removing rules is non-breaking in itself. I'm reasoning from the point of view of a team that needs to adhere to them.

It seems more similar to versioning design documents such as W3C, IEEE etc, where it is common practice to increment the minor version periodically as details are being refined, while major version increments are used for complete redesigns.

@dennisdoomen dennisdoomen merged commit 1eedd41 into dennisdoomen:master Mar 6, 2021
@bkoelman bkoelman deleted the av2201-static-member-access branch March 6, 2021 19:37
mapfel pushed a commit to stepahead/CSharpGuidelines that referenced this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants