implement findAndModify #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manyuanrong
reviewed
Jul 13, 2021
src/types.ts
Outdated
| */ | ||
| export interface FindAndModifyOptions<T> { | ||
| /** | ||
| * Control the order in which documents are found. |
There was a problem hiding this comment.
Fixed. Those must've slipped under the radar.
|
LGTM, a little formatting problem |
|
I forgot something, can you add a test for the new method? |
|
I'll give it a go. It'll probably take a few days, because I'll have to figure out the best way to to that first. |
|
OK, that was quicker, than expected. I added two test cases, one for the update and one for the delete case. |
|
@DerNamenlose ci failed |
|
Fixed. Funny enough: my |
Maybe it's a problem with the Deno version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need the
findAndModifyoperation for a project, so I figured I'd try and contribute it to the driver.This also adds a few interfaces to lock down the interface in terms of types, that could be re-used in other existing interfaces like
findOne, although I didn't change those yet.