add connection event listener support similar to node-redis #475
+238
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uki00a
reviewed
Dec 7, 2024
There was a problem hiding this comment.
Thank you! I'm in favor of this idea. I have only one suggestion: how about managing listeners based on EventTarget? It includes support for AbortSignal, plus it works with Deno as well as Node.js, etc.
The following is an example of strictly defining the type of events to be fired based on EventTarget in Deno:
|
It took way more time than i expected to implement a proper, fully typed event-target based solution due to typescript inconvenience with events. Honestly, i can't spend any more time for this but i think it is done. I am updating the pull request soon. |
uki00a
added a commit
that referenced
this pull request
Dec 8, 2024
Follows-up to #475. Type definitions have been improved so that type errors are caused for unsupported events.
|
Released in v0.37.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to imitate node-redis event listener to make migrations easier. Having an event handler is always useful for logging, debugging and tracing as well.
connect: fires when (re)connected sucessfully
ready: fires when (re)connected and authenticated sucessfully, and ready to send commands
reconnecting: fires only before reconnection with a delay
close: fires after connection is closed for whatever reason
end: fires after connection is closed and terminated, no reconnection is planned
error: fires when an unexpected/uncontrolled error occurs