move away from skypack

denoland · Nov 22, 2023 · a2780c6 · a2780c6
1 parent 0f60e2b
commit a2780c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/github_actions.ts b/github_actions.ts
@@ -1,6 +1,6 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
 
-import { Octokit } from "https://cdn.skypack.dev/@octokit/core@3?dts";
+import { Octokit } from "npm:octokit@^3.1";
 
 export function getGitHubRepository() {
   const repoEnvVar = getEnvVarOrThrow("GITHUB_REPOSITORY");

diff --git a/helpers.ts b/helpers.ts
@@ -67,7 +67,7 @@ export class GitTags {
   /** Gets if the most recent version tag uses a `v` prefix. */
   usesVersionVPrefix() {
     const versionTags = this.getGitVersionTags();
-    versionTags.sort((a, b) => a.version.compare(b.version));
+    versionTags.sort((a, b) => semver.compare(a.version, b.version));
     const mostRecentTag = versionTags[versionTags.length - 1];
     return mostRecentTag?.name.startsWith("v") ?? false;
   }
@@ -89,8 +89,8 @@ export class GitTags {
     let previousVersion;
     for (const tagInfo of this.getGitVersionTags()) {
       const isGtPrevious = previousVersion == null ||
-        previousVersion.version.compare(tagInfo.version) < 0;
-      if (isGtPrevious && tagInfo.version.compare(v) < 0) {
+        semver.compare(previousVersion.version, tagInfo.version) < 0;
+      if (isGtPrevious && semver.compare(tagInfo.version, v) < 0) {
         previousVersion = tagInfo;
       }
     }