Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(): prepare deno std for noUncheckedIndexedAccess #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

syhol
Copy link

@syhol syhol commented Mar 6, 2024

This is part of the effort to rollout the noUncheckedIndexedAccess config for deno std denoland/std#4040

The function getGitHubRepository currently has the implied type

() => { owner: string | undefined, repo: string  | undefined }

It feels cleaner to solve the undefined checking here rather than downstream in deno std _tools/, however if this change isn't acceptable then we can wrap the function in deno std.

Tagging @dsherret since you seem to be a primary maintainer of this repo.

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants