Fixes benchmark page spinner on Edge #2508 (#2525)

denoland · Jun 15, 2019 · 76329cf · 76329cf
1 parent 7b06aa3
commit 76329cf
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/website/app.ts b/website/app.ts
@@ -189,7 +189,7 @@ function formatSecsAsMins(t) {
 }
 
 /**
- * @param dataUrl The url of benchramk data json.
+ * @param dataUrl The url of benchmark data json.
  */
 export function drawCharts(dataUrl) {
   // TODO Using window["location"]["hostname"] instead of
@@ -291,7 +291,9 @@ export function main(): void {
 
     showSpinner();
 
-    drawCharts(u).finally(hideSpinner);
+    drawCharts(u)
+      .then(hideSpinner)
+      .catch(hideSpinner);
   }
   updateCharts();
 

diff --git a/website/benchmarks.html b/website/benchmarks.html
@@ -230,7 +230,7 @@ <h3 id="syscalls">Syscall count <a href="#syscalls">#</a></h3>
     <script src="https://unpkg.com/d3@5.7.0/dist/d3.min.js"></script>
     <script src="https://unpkg.com/c3@0.6.7/c3.min.js"></script>
 
-    <!-- Run "deno bundle app.ts" to generate app.bundle.js -->
+    <!-- Run "deno bundle app.ts app.bundle.js" to generate app.bundle.js -->
     <script src="https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.6/require.min.js"></script>
     <script src="app.bundle.js"></script>
     <script>

diff --git a/website/style.css b/website/style.css
@@ -125,8 +125,8 @@ code {
   left: 50%;
   width: 60px;
   height: 60px;
-  margin-top: -10px;
-  margin-left: -10px;
+  margin-top: -30px;
+  margin-left: -30px;
   border-radius: 50%;
   border: 2px solid #ccc;
   border-top-color: #000;