Skip to content

Commit

Permalink
fix(node): Create additional pipes for child processes (#25016)
Browse files Browse the repository at this point in the history
Linux/macos only currently.

Part of #23524 (fixes it on
platforms other than windows).
Part of #16899  (fixes it on platforms other than windows).

After this PR, playwright is functional on mac/linux.
  • Loading branch information
nathanwhit authored Aug 15, 2024
1 parent 7ca95fc commit 8749d65
Show file tree
Hide file tree
Showing 17 changed files with 776 additions and 295 deletions.
4 changes: 4 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ext/io/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,16 @@ filetime.workspace = true
fs3.workspace = true
log.workspace = true
once_cell.workspace = true
pin-project.workspace = true
tokio.workspace = true
uuid.workspace = true

[target.'cfg(not(windows))'.dependencies]
os_pipe.workspace = true
libc.workspace = true

[target.'cfg(windows)'.dependencies]
winapi = { workspace = true, features = ["winbase", "processenv", "errhandlingapi"] }
rand.workspace = true
parking_lot.workspace = true
windows-sys.workspace = true
Loading

0 comments on commit 8749d65

Please sign in to comment.