feat(unstable): add metadata to Deno.jupyter.broadcast.

denoland · Sep 27, 2023 · 88fea55 · 88fea55
1 parent 1c3485f
commit 88fea55
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/cli/js/40_jupyter.js b/cli/js/40_jupyter.js
@@ -9,8 +9,8 @@ function enableJupyter() {
   } = core.ensureFastOps();
 
   globalThis.Deno.jupyter = {
-    async broadcast(msgType, content) {
-      await op_jupyter_broadcast(msgType, content);
+    async broadcast(msgType, content, metadata = {}) {
+      await op_jupyter_broadcast(msgType, content, metadata);
     },
   };
 }

diff --git a/cli/ops/jupyter.rs b/cli/ops/jupyter.rs
@@ -36,6 +36,7 @@ pub async fn op_jupyter_broadcast(
   state: Rc<RefCell<OpState>>,
   #[string] message_type: String,
   #[serde] content: serde_json::Value,
+  #[serde] metadata: serde_json::Value,
 ) -> Result<(), AnyError> {
   let (iopub_socket, last_execution_request) = {
     let s = state.borrow();
@@ -52,6 +53,7 @@ pub async fn op_jupyter_broadcast(
     last_request
       .new_message(&message_type)
       .with_content(content)
+      .with_metadata(metadata)
       .send(&mut *iopub_socket.lock().await)
       .await?;
   }

diff --git a/cli/tools/jupyter/jupyter_msg.rs b/cli/tools/jupyter/jupyter_msg.rs
@@ -206,6 +206,14 @@ impl JupyterMessage {
     self
   }
 
+  pub(crate) fn with_metadata(
+    mut self,
+    metadata: serde_json::Value,
+  ) -> JupyterMessage {
+    self.metadata = metadata;
+    self
+  }
+
   pub(crate) async fn send<S: zeromq::SocketSend>(
     &self,
     connection: &mut Connection<S>,