fix(cli): dispatch unload on exit (#9088)

denoland · Jan 12, 2021 · fd56fa8 · fd56fa8
1 parent 5c6ab75
commit fd56fa8
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/cli/tests/078_unload_on_exit.ts b/cli/tests/078_unload_on_exit.ts
@@ -0,0 +1,4 @@
+window.onunload = () => {
+  console.log("onunload is called");
+};
+Deno.exit(0);
diff --git a/cli/tests/078_unload_on_exit.ts.out b/cli/tests/078_unload_on_exit.ts.out
@@ -0,0 +1 @@
+[WILDCARD]onunload is called
diff --git a/cli/tests/integration_tests.rs b/cli/tests/integration_tests.rs
@@ -2646,6 +2646,11 @@ itest!(_077_fetch_empty {
   exit_code: 1,
 });
 
+itest!(_078_unload_on_exit {
+  args: "run 078_unload_on_exit.ts",
+  output: "078_unload_on_exit.ts.out",
+});
+
 itest!(js_import_detect {
   args: "run --quiet --reload js_import_detect.ts",
   output: "js_import_detect.ts.out",

diff --git a/runtime/js/30_os.js b/runtime/js/30_os.js
@@ -24,6 +24,9 @@
   }
 
   function exit(code = 0) {
+    // Invokes the `unload` hooks before exiting
+    // ref: https://github.com/denoland/deno/issues/3603
+    window.dispatchEvent(new Event("unload"));
     core.jsonOpSync("op_exit", { code });
     throw new Error("Code not reachable");
   }