Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: don't add registries to deno.suggest.imports.hosts that don't have a manifest #12621

Closed
lucacasonato opened this issue Nov 1, 2021 · 1 comment · Fixed by #12661
Closed
Assignees
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@lucacasonato
Copy link
Member

Just typing out an import slowly results in a bunch of hosts added to .vscode/settings.json:

{
  "deno.enable": true,
  "deno.lint": true,
  "deno.unstable": false,
  "deno.suggest.imports.hosts": {
    "https://deno.land": true,
    "https://x.nest.land": true,
    "https://crux.land": true,
    "https://x.lcas.dev": true,
    "https://cdn.skypack.dev": false,
    "https://esm.sh": false,
    "https://skypack.": false,
    "https://cdn..sh": false,
    "https://e": false,
    "https://esm": false,
    "https://esm,.": false,
    "https://esm.": false,
    "https://esm.s": false
  }
}

If an origin does not provide a manifest, we should cache the non existence of a manifest in the registry cache, and not add anything to the settings file (this is what the old extension used to do).

@lucacasonato lucacasonato added lsp related to the language server bug Something isn't working correctly labels Nov 1, 2021
@kitsonk kitsonk self-assigned this Nov 2, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Nov 2, 2021

Yeah, that makes sense... will work on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants