Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-typescript-types not working in LSP anymore #12675

Closed
lucacasonato opened this issue Nov 7, 2021 · 3 comments · Fixed by #12683
Closed

x-typescript-types not working in LSP anymore #12675

lucacasonato opened this issue Nov 7, 2021 · 3 comments · Fixed by #12683
Assignees
Labels
bug Something isn't working correctly lsp related to the language server
Milestone

Comments

@lucacasonato
Copy link
Member

Deno 1.15.3:

image

Latest Deno Canary (0f8299d)

image

@lucacasonato lucacasonato added bug Something isn't working correctly lsp related to the language server labels Nov 7, 2021
@lucacasonato lucacasonato added this to the 1.16.0 milestone Nov 7, 2021
@kitsonk kitsonk self-assigned this Nov 7, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Nov 7, 2021

Working on it now.

@kitsonk
Copy link
Contributor

kitsonk commented Nov 7, 2021

We didn't have a test for it, and sure enough, I forgot to handle it when I refactored the code to use deno_graph. 😢

I've got a failing test now, and should have a PR with the fix soon.

@kitsonk
Copy link
Contributor

kitsonk commented Nov 7, 2021

For the record, it is just the hover text. The type checking and goto definition and the like actually work behind the scenes. This has to do with how we properly place the value of that header in the maybe_types_dependency slot of the target module, instead of "bubbling" it up into the maybe_type slot of the importing module. Need to reflect this in the over text though, so people know it has resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants