Undici doesn't work with npm specifiers

[khrj]

Undici returns a ConnectTimeoutError when attempting any request.

Many npm modules depend on undici, node's fetch api implementation used as a module.

Reproducible example:

import { request } from "npm:undici"
await request("https://www.example.com")

fails with

error: Uncaught (in promise) ConnectTimeoutError: Connect Timeout Error
    at onConnectTimeout (file:///home/khushraj/.cache/deno/npm/registry.npmjs.org/undici/5.12.0/lib/core/connect.js:133:24)
    at file:///home/khushraj/.cache/deno/npm/registry.npmjs.org/undici/5.12.0/lib/core/connect.js:80:46
    at Timeout.<anonymous> (file:///home/khushraj/.cache/deno/npm/registry.npmjs.org/undici/5.12.0/lib/core/connect.js:121:9)
    at https://deno.land/std@0.164.0/node/timers.ts:21:15
    at Object.action (deno:ext/web/02_timers.js:147:13)
    at handleTimerMacrotask (deno:ext/web/02_timers.js:64:12)

Example of module broken: #16684

[kt3k]

I found 3 issues for this:

• Timeout.prototype.refresh method is missing fix(node/timers): implement timeout.refresh std#2919
• "secureConnect" event isn't emitted when the protocol is "https" fix(node/tls): implement secureConnect event std#2926
• TCP.unref is not available (We need Deno.TcpConn.unref first, and then need to shim TCP.unref using it.)
  • ref: https://github.com/nodejs/undici/blob/80700c6287ef5fbb0eb2b669192ac7109ec01f57/lib/client.js#L1175
• types.isProxy is not a function

[bartlomieju]

Seems like there's another problem: #15427 (comment)

[khrj]

Any progress on Deno.TcpConn.unref / is there something blocking it?

[bartlomieju]

Any progress on Deno.TcpConn.unref / is there something blocking it?

No progress, no one has picked it up yet. PRs are most welcome!

[bartlomieju]

FYI I'm working on the ref/unref functionality in #17170

[bartlomieju]

@kt3k could you take over this issue now that unref API for connection is implemented?

[kt3k]

Sure!

[khrj]

@kt3k as of 1.29.2, this seems to be completely functional now? Is there something that is still pending, or should I close this issue? The example in the original post works now. Thanks!

[Jakob5358]

@khrj It still seems to time out for me, both on 1.29.2 and on latest canary.

import { request } from 'npm:undici';

const res = await request('https://jsonplaceholder.typicode.com/todos/1');
console.log(res.statusCode);

[khrj]

Apart from being rather slow, it works for me:

Running deno from master

[khrj]

In comparison:

[Jakob5358]

Apart from being rather slow, it works for me:

Running deno from master

Weird, this is what happens for me running deno... not from master but from latest canary.

Maybe I'm not using the latest deno_std version for node compat and you need to set that manually idk-

[kt3k]

@Jakob5358 Is https://jsonplaceholder.typicode.com/todos/1 accessible from your environment?

[Jakob5358]

@Jakob5358 Is https://jsonplaceholder.typicode.com/todos/1 accessible from your environment?

Yes but it now works in the latest version thanks y'all