Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deno fmt and deno lint should ignore files set in .gitignore #20185

Closed
marvinhagemeister opened this issue Aug 17, 2023 · 5 comments
Closed
Labels
feat new feature (which has been agreed to/accepted)

Comments

@marvinhagemeister
Copy link
Contributor

Would be nice if deno fmt and deno lint were aware of .gitignore and would ignore files/paths listed in there. Currently, we have to duplicate those paths in the exclude rules for deno fmt and deno lint.

Related denoland/fresh#1652

@marvinhagemeister marvinhagemeister added the feat new feature (which has been agreed to/accepted) label Aug 17, 2023
@marvinhagemeister marvinhagemeister changed the title feat: deno fmt and deno lint should ignore files set in .gitignore by default feat: deno fmt and deno lint should ignore files set in .gitignore Aug 17, 2023
@bartlomieju
Copy link
Member

@dsherret thoughts on this? I think it makes sense and would be very convenient.

@marvinhagemeister
Copy link
Contributor Author

Just checked with prettier and eslint and both respect .gitignore automatically.

@bartlomieju
Copy link
Member

If we decide to do it, we should probably use ignore crate.

@dsherret
Copy link
Member

I think we shouldn't introduce additional config files. Although it's convient, it really ups the complexity of things. Also, although git is now more widespread there are still other version control systems.

@bartlomieju
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat new feature (which has been agreed to/accepted)
Projects
None yet
Development

No branches or pull requests

3 participants