feat: fmt and lint respect .gitignore file #26897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2024
nathanwhit
pushed a commit
to denoland/fresh
that referenced
this pull request
Dec 4, 2024
Resolves #2771 Specifically the `init` test fails: ``` deno test -A ./init ``` Output: ``` error: No target files found. ----- output end ----- init - fmt, lint, and type check project ... FAILED (157ms) init with tailwind - fmt, lint, and type check project ... ------- output ------- Task check deno fmt --check && deno lint && deno check **/*.ts && deno check **/*.tsx error: No target files found. ----- output end ----- init with tailwind - fmt, lint, and type check project ... FAILED (136ms) ``` Seems to be a gitignore issue, and _probably_ relates to the new features that ["lint an fmt respect gitignore"](denoland/deno#26897): - the gitignore file in the fresh project has `tmp-*` - the tmp directory created by the init test matches that pattern: `tmp-${hash}` - changing the tmp directory to `tmp_${hash}` resolves the issue 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26573