feat(lint): skip build directories by default #26635
Conversation
| @@ -425,13 +425,25 @@ impl WorkspaceLinter { | |||
| } | |||
| } | |||
|
|
|||
| const DEFAULT_IGNORED_DIRS: [&'static str; 5] = | |||
| [".config", ".next", ".vite", "dist", "target"]; | |||
There was a problem hiding this comment.
The problem with doing this is we're not setting users up for success. They should be adding the following to their project:
{
"exclude": [
".next"
]
}...this will give them better performance because now all tooling will ignore that folder (especially the lsp).
If we do this, then we should have something in deno_config that automatically adds this (maybe if the workspace contains certain dependencies, but that would be more work for us to do on startup). Overall though, I don't think ignoring build folders is something that's hard for users to grasp and by doing this we're not teaching users about it. We're also making Deno more complex by having all these little rules where it works one way for this kind of folder and another way for another folder. Can we offer a suggestion for people to exclude these folders instead when they get lint rule errors or deno fmt --check errors in them?
Question: Why do we need this if we already ignore gitignored folders?
|
Closing in favor of #26897 which seems more desirable. |
Closes #26573