Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling monitorEventLoopDelay causes Not implemented error #20961

Closed
5d-jh opened this issue Oct 24, 2023 · 1 comment · Fixed by #26905
Closed

calling monitorEventLoopDelay causes Not implemented error #20961

5d-jh opened this issue Oct 24, 2023 · 1 comment · Fixed by #26905

Comments

@5d-jh
Copy link

5d-jh commented Oct 24, 2023

Throwing Not implemented in perf_hooks. monitorEventLoopDelay breaks prom-client's eventLoopLag function. Since prom-client provides workaround logic when it's not exist on older nodejs runtime, set monitorEventLoopDelay to undefined instead would work seamlessly.

Aside from prom-client, setting undefined instead of placeholder function seems more intuitive.

@SebastienGllmt
Copy link

SebastienGllmt commented Nov 22, 2024

There are multiple things in perf_hooks not implemented. For example, createHistogram is used by piscina but it's not implemented in deno which leads to a crash

Notably, (more generally than the piscina issue), I believe the current list of missing APIs at the time of posting are

From the performance object

  • clearMeasures
  • clearMeasures
  • clearResourceTimings
  • getEntries
  • setResourceTimingBufferSize

Top-level functions:

  • createHistogram

The following classes:

  • PerformanceMark
  • PerformanceMeasure
  • PerformanceNodeEntry
  • PerformanceNodeTiming
  • PerformanceResourceTiming
  • PerformanceObserverEntryList
  • Histogram
  • IntervalHistogram
  • RecordableHistogram

just sharing the list here so that if people search any of these in the Deno repo they find this message in the result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants