You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Throwing Not implemented in perf_hooks. monitorEventLoopDelay breaks prom-client's eventLoopLag function. Since prom-client provides workaround logic when it's not exist on older nodejs runtime, set monitorEventLoopDelay to undefined instead would work seamlessly.
Aside from prom-client, setting undefined instead of placeholder function seems more intuitive.
The text was updated successfully, but these errors were encountered:
There are multiple things in perf_hooks not implemented. For example, createHistogram is used by piscina but it's not implemented in deno which leads to a crash
Notably, (more generally than the piscina issue), I believe the current list of missing APIs at the time of posting are
From the performance object
clearMeasures
clearMeasures
clearResourceTimings
getEntries
setResourceTimingBufferSize
Top-level functions:
createHistogram
The following classes:
PerformanceMark
PerformanceMeasure
PerformanceNodeEntry
PerformanceNodeTiming
PerformanceResourceTiming
PerformanceObserverEntryList
Histogram
IntervalHistogram
RecordableHistogram
just sharing the list here so that if people search any of these in the Deno repo they find this message in the result
Throwing
Not implemented
inperf_hooks. monitorEventLoopDelay
breaks prom-client'seventLoopLag
function. Since prom-client provides workaround logic when it's not exist on older nodejs runtime, set monitorEventLoopDelay to undefined instead would work seamlessly.Aside from
prom-client
, setting undefined instead of placeholder function seems more intuitive.The text was updated successfully, but these errors were encountered: