Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node:crypto private KeyObject tracking issue #21124

Closed
21 of 37 tasks
littledivy opened this issue Nov 9, 2023 · 1 comment · Fixed by #24463
Closed
21 of 37 tasks

node:crypto private KeyObject tracking issue #21124

littledivy opened this issue Nov 9, 2023 · 1 comment · Fixed by #24463
Assignees
@littledivy
Labels
crypto Related to node:crypto or WebCrypto good first issue Good for newcomers node API Related to various "node:*" modules APIs node compat

Comments

@littledivy
Copy link
Member

  • PrivateKey#asymmetricKeyDetails
  • PrivateKey#asymmetricKeyType
  • PrivateKey#export
  • createPrivateKey
    • RSA
      • pem
        • pkcs8 (PRIVATE KEY)
        • pkcs1 (RSA PRIVATE KEY)
      • der
        • pkcs1
        • pkcs8
        • sec1
      • jwk
    • RSA-PSS
      • pem
        • pkcs8 (PRIVATE KEY)
        • pkcs1 (RSA PRIVATE KEY)
      • der
        • pkcs1
        • pkcs8
        • sec1
      • jwk
    • EC
      • pem
        • pkcs8
        • pkcs1
      • der
        • pkcs1
        • pkcs8
        • sec1
      • jwk
    • DSA
    • x25519
    • x448
    • ed25519
    • ed448
    • dh

Initial PR: #20981
@littledivy littledivy self-assigned this Nov 9, 2023
This was referenced Nov 9, 2023
Merged
Closed
@littledivy littledivy added the good first issue Good for newcomers label Nov 10, 2023
@littledivy littledivy mentioned this issue Nov 21, 2023
Merged
littledivy added a commit that referenced this issue Dec 3, 2023
@littledivy
fix(ext/node): sign with PEM private keys (#21287)
32438d2 
Add support for signing with a RSA PEM private key: `pkcs8` and `pkcs1`.

Fixes #18972
Ref #21124 

Verified fix with `npm:sshpk`. Unverfied but fixes
`npm:google-auth-library`, `npm:web-push` & `oracle/oci-typescript-sdk`

---------

Signed-off-by: Divy Srivastava <dj.srivastava23@gmail.com>
@muddlebee
Copy link
Contributor

@littledivy is there anything I can pick up from here? 👀

@bartlomieju bartlomieju added the node API Related to various "node:*" modules APIs label Mar 4, 2024
@littledivy littledivy mentioned this issue Apr 29, 2024
Merged
littledivy added a commit that referenced this issue Apr 29, 2024
@littledivy
fix(ext/node): exporting rsa public keys (#23596)
b02ffec 
Initial support for exporting rsa public KeyObject.

Current assumption is that RSA keys are stored in pkcs1 der format in
key storage.

Ref #23471 
Ref #18928
Ref #21124
@lucacasonato lucacasonato added the crypto Related to node:crypto or WebCrypto label Jun 8, 2024
@lucacasonato lucacasonato mentioned this issue Jun 8, 2024
Closed
This was referenced Jun 23, 2024
Closed
Closed
Open
@lucacasonato lucacasonato mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@littledivy littledivy

Labels
crypto Related to node:crypto or WebCrypto good first issue Good for newcomers node API Related to various "node:*" modules APIs node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ext/node): rewrite crypto keys lucacasonato/deno
4 participants
@lucacasonato @muddlebee @bartlomieju @littledivy