Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing reexport of validateHeaderName and validateHeaderValue in node:http #22614

Closed
mash-graz opened this issue Feb 27, 2024 · 0 comments · Fixed by #22616
Closed

missing reexport of validateHeaderName and validateHeaderValue in node:http #22614

mash-graz opened this issue Feb 27, 2024 · 0 comments · Fixed by #22616

Comments

@mash-graz
Copy link
Contributor

These two functions are already implemented in ext:deno_node/_http_outgoing.ts and are partially used in node:http, but they are not publicly reexported there.
This was referenced Feb 28, 2024
Merged
Merged
bartlomieju pushed a commit that referenced this issue Mar 10, 2024
@mash-graz
fix(node:http) Export validateHeaderName and validateHeaderValue …
16dbbfa 
…functions (#22616)

Modify `_http_outgoing.ts` to support the extended signature of
`validateHeaderName()` used since node v19.5.0/v18.14.0 by adding the
`label` parameter. (see:
https://nodejs.org/api/http.html#httpvalidateheadernamename-label)

Making both validation functions accessible as public exports of
`node:http`

Fixes: #22614
nathanwhit pushed a commit that referenced this issue Mar 14, 2024
@mash-graz @nathanwhit
fix(node:http) Export validateHeaderName and validateHeaderValue …
6057ddd 
…functions (#22616)

Modify `_http_outgoing.ts` to support the extended signature of
`validateHeaderName()` used since node v19.5.0/v18.14.0 by adding the
`label` parameter. (see:
https://nodejs.org/api/http.html#httpvalidateheadernamename-label)

Making both validation functions accessible as public exports of
`node:http`

Fixes: #22614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node:http) Export validateHeaderName and validateHeaderValue functions
1 participant
@mash-graz