Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move //js to //cli/js #2747

Closed
ry opened this issue Aug 7, 2019 · 2 comments
Closed

Move //js to //cli/js #2747

ry opened this issue Aug 7, 2019 · 2 comments
Labels
build build system or continuous integration related

Comments

@ry
Copy link
Member

ry commented Aug 7, 2019

All of the files in //js belong the the CLI crate. We should make this more apparent. There is the additional benefit of rebuilding-on-change when using 'cargo build'.

This should not be done until #2730 is complete.

This should maybe wait for #2740 to be complete.
@ry ry added the build build system or continuous integration related label Aug 7, 2019
@bartlomieju
Copy link
Member

Close in favor of #2852?

@ry
Copy link
Member Author

ry commented Sep 3, 2019

Yes thanks

@ry ry closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build build system or continuous integration related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ry @bartlomieju