Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg directory structure #2852

Closed
ry opened this issue Sep 2, 2019 · 6 comments
Closed

reorg directory structure #2852

ry opened this issue Sep 2, 2019 · 6 comments

Comments

@ry
Copy link
Member

ry commented Sep 2, 2019

After #2825 lands, I want to change the layout of our source tree. #2825 adds two new crates, bringing our total to 4. I think we need to move them all into a special src directory to make grepping easier, and easier for newbies to navigate.

After #2825, the //js directory is only used by cli_snapshots, I think it should be moved to a subdirectory of that crate.

Thus I propose

//src/
//src/core/
//src/core/libdeno/
//src/cli/
//src/cli/ops
//src/cli_snapshots/
//src/cli_snapshots/js/
//src/deno_typescript/

deno_typescript is a long name - I'd like to use something shorter. But I'm not sure what a good name would be that is descriptive yet short.. I think we can punt on that.

Also I am strongly considering merging the deno_std tree into this repo. I think //src/std would be logical. I will do that in a separate PR, but just want to mention it.

@bartlomieju
Copy link
Member

After #2825, the //js directory is only used by cli_snapshots, I think it should be moved to a subdirectory of that crate.

How about splitting that into src/runtime and src/compiler? Once GN is not needed anymore both of them would contain minimal build.rs files (just different entry points).

deno_typescript is a long name - I'd like to use something shorter. But I'm not sure what a good name would be that is descriptive yet short.. I think we can punt on that.

ts_bundler?

Also I am strongly considering merging the deno_std tree into this repo. I think //src/std would be logical. I will do that in a separate PR, but just want to mention it.

Why not a git submodule? That would still keep PRs and issues separate - should be easier to manage than having everything in this repo.

@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Sep 2, 2019

Why not a git submodule? That would still keep PRs and issues separate - should be easier to manage than having everything in this repo.

I think that's how it currently is... it's vendored in the deps cache in //js/deps.

@ry
Copy link
Member Author

ry commented Sep 2, 2019

Why not a git submodule?

So git tags applied to the main deno apply also to std. Also I find it hard to keep track of PRs in the other repo...

@bartlomieju
Copy link
Member

Why not a git submodule?

So git tags applied to the main deno apply also to std.

Got it 👍although I think it may obscure build process again

Also I find it hard to keep track of PRs in the other repo...

Fair enough, I'm just fearing for that once we get more adoption

@bartlomieju
Copy link
Member

@ry done or do you still want to move everything under src/?

@ry
Copy link
Member Author

ry commented Oct 12, 2019

Done. I’m not going to pursue the src dir.

@ry ry closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants