-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge deno_std into deno repo #603
Comments
Just a question, deno_std will still not be shipped with the deno runtime right? |
Correct - deno_std will still be available via https://Deno.land/std This is just about being able to have CI testing both the std modules and internal code. |
Also this move requires the review of current issues of the repo. Moving the related ones and closing the staling. (just to have it in consideration) |
Won't this cause longer and more frequent builds since CI will run both deno and deno_std tests for anything? So |
Yes, this will certainly increase the CI time for deno_std - it won't for deno. We are moving to Github Actions in Deno - and that should improve the CI time... But yes, expect it to be about 15 minutes to get green. The trade off is worth it. We need to have better understanding of how changes in core effect std and vise versa. Ultimately I think this merge will increase our agility. |
Tests of deno_std are really fast so i'm not concerned with that. The only concern is the occurence of builds yes. |
Hmm... It must be hard task for contributors. I know there are some difficulties of managing parallel projects. But "all at once" is not good idea imo. On the first step, only modules depended by core repository should be moved, can you? E.g. |
Now that we’ve moved CI to Github actions and it’s working well, we’ve started the transition |
Also maybe a |
deno_std and deno have circular dependencies between them - and it's increasingly difficult as our codebase grows to keep them in sync.
I plan to merge the deno_std repo into deno in the near future.
I want to complete a few things first
The text was updated successfully, but these errors were encountered: