Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"cargo test" should be the main test runner #2933

Closed
4 of 10 tasks
ry opened this issue Sep 12, 2019 · 1 comment · Fixed by #2967
Closed
4 of 10 tasks

"cargo test" should be the main test runner #2933

ry opened this issue Sep 12, 2019 · 1 comment · Fixed by #2967
Labels
build build system or continuous integration related

Comments

@ry
Copy link
Member

ry commented Sep 12, 2019 •
edited
Loading

Since #2608 cargo build is our main build front-end. It makes sense that cargo test should also be the main test runner.

Currently to run the tests we call tools/test.py. test.py executes many different tests outside of the Rust unit tests.

  • Make the integrations tests into Rust tests Make integration tests rust unit tests #2881
  • Have the ability to start tools/http_server.py for individual rust tests.
  • Call various python tests from Rust (TestSetup, TestUtil, TestBenchmark)
  • Port JsUnitTests to Rust. That is call js/unit_test_runner.ts from a Rust test (while http_server is running)
  • Port TestFetch to Rust
  • Port TestRepl to Rust
  • Port TestIsTty to Rust
  • Port permission_prompt_tests to Rust
  • Port complex_permissions_tests to Rust
  • Port TestFmt to Rust

This issue can be closed when test.py is deleted and the CI updated to call cargo test.
@ry ry added the build build system or continuous integration related label Sep 12, 2019
@kt3k kt3k mentioned this issue Sep 15, 2019
Closed
@nayeemrmn nayeemrmn mentioned this issue Sep 15, 2019
Closed
@ry ry mentioned this issue Sep 16, 2019
Merged
ry added a commit that referenced this issue Sep 17, 2019
@ry
Move integration tests to //cli/tests/ (#2964)
9cfdc60 
This ensures the deno executable is properly created before running the integration tests.

Also allows deno_cli to be used as a lib. Docs are now properly generated: https://docs.rs/deno_cli/0.18.4/deno_cli/

Towards #2933
Prep for #2955
This was referenced Sep 17, 2019
Merged
Closed
@ry ry closed this as completed in #2967 Sep 19, 2019
ry added a commit that referenced this issue Sep 19, 2019
@ry
Remove test.py, use cargo test as test frontend (#2967)
56ac638 
Fixes #2933
@ry
Copy link
Member Author

ry commented Sep 19, 2019

Follow up issues moved to #2988

@lukahartwig lukahartwig mentioned this issue Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build build system or continuous integration related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cargo test ry/deno
1 participant
@ry