Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo test #2967

Merged
merged 1 commit into from
Sep 19, 2019
Merged

cargo test #2967

merged 1 commit into from
Sep 19, 2019

Conversation

ry
Copy link
Member

@ry ry commented Sep 17, 2019 •
edited
Loading

Fixes #2933

@ry ry mentioned this pull request Sep 17, 2019
Closed
kt3k
kt3k reviewed Sep 17, 2019
View reviewed changes
cli/test_util.rs Outdated Show resolved Hide resolved
@ry
Copy link
Member Author

ry commented Sep 17, 2019

This is very close to working - but I'm having difficulty getting it to go green on CI....

@ry ry force-pushed the cargo_test_working branch 3 times, most recently from 056b28d to e4c52e0 Compare September 19, 2019 01:57
@ry ry changed the title Remove test.py, use cargo test as test frontend cargo test Sep 19, 2019
@ry ry force-pushed the cargo_test_working branch 2 times, most recently from 719f092 to 1f9a2a3 Compare September 19, 2019 16:58
@ry ry force-pushed the cargo_test_working branch from 1f9a2a3 to e3677c8 Compare September 19, 2019 16:59
piscisaureus
piscisaureus approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I thought I had approved this already

@ry ry merged commit 56ac638 into denoland:master Sep 19, 2019
@kt3k
Copy link
Member

kt3k commented Sep 20, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k left review comments

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"cargo test" should be the main test runner
3 participants
@ry @kt3k @piscisaureus