Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorg tests #2955

Closed
wants to merge 11 commits into from
Closed

Reorg tests #2955

wants to merge 11 commits into from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 15, 2019 •
edited
Loading

ref: #2933

Call various python tests from Rust (TestSetup, TestUtil, TestBenchmark)

This PR addresses the above part of the issue #2933.

I created a crate cli/tty_tests because those tests which use tty_capture seem failing when running with other tests in parallel. So I created a separated crate, put those tests in it, and ran them in serial.

@kt3k kt3k marked this pull request as ready for review September 15, 2019 10:03
bartlomieju
bartlomieju reviewed Sep 15, 2019
View reviewed changes
cli/tty_tests/lib.rs Show resolved Hide resolved
tools/test.py Outdated Show resolved Hide resolved
hayd
hayd reviewed Sep 15, 2019
View reviewed changes
tools/test.py Show resolved Hide resolved
@kt3k
Copy link
Member Author

kt3k commented Sep 16, 2019

I'll update the handling of options soon.

@kt3k kt3k force-pushed the feature/reorg-tests branch from 9cb1472 to b01041f Compare September 16, 2019 15:15
@kt3k kt3k force-pushed the feature/reorg-tests branch from b01041f to 026d3fa Compare September 16, 2019 15:51
@ry ry mentioned this pull request Sep 16, 2019
Closed
@kt3k
Copy link
Member Author

kt3k commented Sep 16, 2019

Passed sys.argv[1:] to cargo test. Now you can filter tests with ./tools/test.py <pattern>, and you can test agaist release with ./tools/test.py --release.

@ry
Copy link
Member

ry commented Sep 16, 2019 •
edited
Loading

@kt3k I'm going to just finish off #2933 in this PR. I've figured out how to run the http_server.py during the rust tests. So I've now removed test.py and will try to get it to go green.

@ry ry mentioned this pull request Sep 16, 2019
Merged
ry added a commit that referenced this pull request Sep 17, 2019
@ry
Move integration tests to //cli/tests/ (#2964)
9cfdc60 
This ensures the deno executable is properly created before running the integration tests.

Also allows deno_cli to be used as a lib. Docs are now properly generated: https://docs.rs/deno_cli/0.18.4/deno_cli/

Towards #2933
Prep for #2955
@ry
Copy link
Member

ry commented Sep 17, 2019 •
edited
Loading

Sorry I hope I'm not stepping on your toes @kt3k. I've got "cargo test" more or less working.

Let's move the discussion to #2967

@ry ry closed this Sep 17, 2019
@kt3k
Copy link
Member Author

kt3k commented Sep 17, 2019

@ry Thanks! Great! No problem.

ry referenced this pull request Sep 19, 2019
@ry
Remove test.py, use cargo test as test frontend (#2967)
56ac638 
Fixes #2933
@kt3k kt3k deleted the feature/reorg-tests branch January 21, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@hayd hayd hayd left review comments

@ry ry ry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kt3k @ry @hayd @bartlomieju