Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further work now that "cargo test" is the test runner #2988

Closed
5 of 7 tasks
ry opened this issue Sep 19, 2019 · 5 comments
Closed
5 of 7 tasks

Further work now that "cargo test" is the test runner #2988

ry opened this issue Sep 19, 2019 · 5 comments
Labels
build build system or continuous integration related

Comments

@ry
Copy link
Member

ry commented Sep 19, 2019

As of 56ac638, "cargo test" is the main and only test runner. test.py is gone.

Currently the "cargo test" test runner calls into python to launch the tests. See //cli/tests/integration_tests.rs

  • Port TestFetch to Rust
  • Port TestRepl to Rust TestRepl Port to Rust #4096
  • Port TestIsTty to Rust (These are currently in //cli/tests/tty_tests.rs, but should be merged into //cli/tests/integration_tests.rs)
  • Port permission_prompt_tests to Rust Port permission_prompt_tests to Rust #4129
  • Port complex_permissions_tests to Rust
  • Port TestFmt to Rust
  • Additionally we also need should remove the top-level //tests symlink - which requires carefully updating many references in the code base.
@ry ry added the build build system or continuous integration related label Sep 19, 2019
@hayd
Copy link
Contributor

hayd commented Sep 19, 2019

Related port tools/http_server.py to rust #1453 .

@jsouto18
Copy link
Contributor

@ry Hey, I would like to help porting TestRepl to Rust. How should I proceed to contribute for that task? Should I create a PR porting TestRepl only?

@ry
Copy link
Member Author

ry commented Feb 23, 2020

@jsouto18 Go for it - it would be very welcome. Here's the python code https://github.com/denoland/deno/blob/master/tools/repl_test.py The Rust version should end up here https://github.com/denoland/deno/blob/master/cli/tests/integration_tests.rs
It should be a separate PR for TestRepl only.

ry pushed a commit that referenced this issue Feb 24, 2020
@jsouto18
Copy link
Contributor

@ry I'll try to close this issue by porting the remaining tests. Just one question, will it also resolve #3129?

@bartlomieju
Copy link
Member

Remaining tests were ported in #4200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build system or continuous integration related
Projects
None yet
Development

No branches or pull requests

4 participants