Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Complex Permissions Tests to Rust #4200

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

jsouto18
Copy link
Contributor

@jsouto18 jsouto18 commented Mar 1, 2020

This PR should close the task Port complex_permissions_tests to Rust currently open on #2988. It should also close #3129.

@jsouto18
Copy link
Contributor Author

jsouto18 commented Mar 1, 2020

@ry can you review this PR? For some reason no one shows up in the Reviewers tab?

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you very much @jsouto18

@ry ry merged commit 809019d into denoland:master Mar 2, 2020
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Mar 3, 2020
mhvsa pushed a commit to mhvsa/deno that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants