Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate Deno.iter and Deno.iterSync #10025

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

lucacasonato
Copy link
Member

This commit marks the Deno.iter and Deno.iterSync utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/util:
denoland/std#843.

Towards #9795

This commit marks the `Deno.iter` and `Deno.iterSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/util:
denoland/std#843.
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As we get closer to 2.0, we might want to turn on "hard deprecation" mode where we actually print a warning message if you use these APIs.

@lucacasonato lucacasonato merged commit d849c87 into denoland:main Apr 5, 2021
@lucacasonato lucacasonato deleted the deprecate-iter-itersync branch April 5, 2021 22:05
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Apr 6, 2021
This commit marks the `Deno.iter` and `Deno.iterSync` utils as
deprecated, and schedules them for removal in Deno 2.0. These
utilities are implemented in pure JS, so should not be part of the
Deno namespace.

These utilities are now available in std/io/util:
denoland/std#843.
@nayeemrmn nayeemrmn mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants