chore: align Headers to spec
#10199
Merged
chore: align Headers to spec
#10199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
align_headers
branch
from
22325da to
9bd1500
Compare
lucacasonato
commented
Apr 15, 2021
Comment on lines
+11
to
+78
| const ASCII_DIGIT = ["\u0030-\u0039"]; | ||
| const ASCII_UPPER_ALPHA = ["\u0041-\u005A"]; | ||
| const ASCII_LOWER_ALPHA = ["\u0061-\u007A"]; | ||
| const ASCII_ALPHA = [...ASCII_UPPER_ALPHA, ...ASCII_LOWER_ALPHA]; | ||
| const ASCII_ALPHANUMERIC = [...ASCII_DIGIT, ...ASCII_ALPHA]; | ||
|
|
||
| const HTTP_TAB_OR_SPACE = ["\u0009", "\u0020"]; | ||
| const HTTP_WHITESPACE = ["\u000A", "\u000D", ...HTTP_TAB_OR_SPACE]; | ||
|
|
||
| const HTTP_TOKEN_CODE_POINT = [ | ||
| "\u0021", | ||
| "\u0023", | ||
| "\u0024", | ||
| "\u0025", | ||
| "\u0026", | ||
| "\u0027", | ||
| "\u002A", | ||
| "\u002B", | ||
| "\u002D", | ||
| "\u002E", | ||
| "\u005E", | ||
| "\u005F", | ||
| "\u0060", | ||
| "\u007C", | ||
| "\u007E", | ||
| ...ASCII_ALPHANUMERIC, | ||
| ]; | ||
| const HTTP_TOKEN_CODE_POINT_RE = new RegExp( | ||
| `^[${regexMatcher(HTTP_TOKEN_CODE_POINT)}]+$`, | ||
| ); | ||
| const HTTP_QUOTED_STRING_TOKEN_POINT = [ | ||
| "\u0009", | ||
| "\u0020-\u007E", | ||
| "\u0080-\u00FF", | ||
| ]; | ||
| const HTTP_QUOTED_STRING_TOKEN_POINT_RE = new RegExp( | ||
| `^[${regexMatcher(HTTP_QUOTED_STRING_TOKEN_POINT)}]+$`, | ||
| ); | ||
| const HTTP_WHITESPACE_MATCHER = regexMatcher(HTTP_WHITESPACE); | ||
| const HTTP_WHITESPACE_PREFIX_RE = new RegExp( | ||
| `^[${HTTP_WHITESPACE_MATCHER}]+`, | ||
| "g", | ||
| ); | ||
| const HTTP_WHITESPACE_SUFFIX_RE = new RegExp( | ||
| `[${HTTP_WHITESPACE_MATCHER}]+$`, | ||
| "g", | ||
| ); | ||
|
|
||
| /** | ||
| * Turn a string of chars into a regex safe matcher. | ||
| * @param {string[]} chars | ||
| * @returns {string} | ||
| */ | ||
| function regexMatcher(chars) { | ||
| const matchers = chars.map((char) => { | ||
| if (char.length === 1) { | ||
| return `\\u${char.charCodeAt(0).toString(16).padStart(4, "0")}`; | ||
| } else if (char.length === 3 && char[1] === "-") { | ||
| return `\\u${char.charCodeAt(0).toString(16).padStart(4, "0")}-\\u${ | ||
| char.charCodeAt(2).toString(16).padStart(4, "0") | ||
| }`; | ||
| } else { | ||
| throw TypeError("unreachable"); | ||
| } | ||
| }); | ||
| return matchers.join(""); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is all just moved from //op_crates/web/01_mimesniff.js
Comment on lines
+689
to
+695
| "headers-basic.any.js": true, | ||
| "headers-casing.any.js": true, | ||
| "headers-combine.any.js": true, | ||
| "headers-errors.any.js": true, | ||
| "headers-normalize.any.js": true, | ||
| "headers-record.any.js": true, | ||
| "headers-structure.any.js": true |
There was a problem hiding this comment.
All relevant tests pass.
|
The |
lucacasonato
commented
Apr 15, 2021
Comment on lines
-380
to
-389
| unitTest(function headersSetDuplicateCookieKey(): void { | ||
| const headers = new Headers([["Set-Cookie", "foo=bar"]]); | ||
| headers.set("set-Cookie", "foo=baz"); | ||
| headers.set("set-cookie", "bar=qat"); | ||
| const actual = [...headers]; | ||
| assertEquals(actual, [ | ||
| ["set-cookie", "foo=baz"], | ||
| ["set-cookie", "bar=qat"], | ||
| ]); | ||
| }); |
There was a problem hiding this comment.
This test is plain wrong. headers.set is not the same as append. It removes existing headers of that name before insertion. See https://fetch.spec.whatwg.org/#concept-header-list-set
lucacasonato
force-pushed
the
align_headers
branch
from
83af2b3 to
f337975
Compare
28 tasks
lucacasonato
force-pushed
the
align_headers
branch
from
f337975 to
a10296d
Compare
This commit aligns `Headers` to spec. It also removes the now unused 03_dom_iterable.js file. We now pass all relevant `Headers` WPT. We do not implement any sort of header filtering, as we are a server side runtime. This is likely not the most efficient implementation of `Headers` yet. It is however spec compliant. Once all the APIs in the `HTTP` hot loop are correct we can start optimizing them. It is likely that this commit reduces bench throughput temporarily.
lucacasonato
force-pushed
the
align_headers
branch
from
a10296d to
b3cb67e
Compare
|
This PR caused a fairly severe performance degradation in the performance of std/http/server.ts
|
|
This is most likely caused by the O(n^2) complexity of https://github.com/denoland/deno/blob/main/extensions/fetch/20_headers.js#L178-L207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aligns
Headersto spec. It also removes the now unused03_dom_iterable.js file. We now pass all relevant
HeadersWPT. We donot implement any sort of header filtering, as we are a server side
runtime.
This is likely not the most efficient implementation of
Headersyet. It ishowever spec compliant. Once all the APIs in the
HTTPhot loop arecorrect we can start optimizing them. It is likely that this reduces bench
throughput temporarily.