feat(lsp): add internal debugging logging #10438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Apr 30, 2021
ry
reviewed
Apr 30, 2021
cli/lsp/performance.rs
Outdated
| let name = name.as_ref(); | ||
| let mut counts = self.counts.lock().unwrap(); | ||
| let count = counts.entry(name.to_string()).or_insert(0); | ||
| *count += 1; | ||
| if self.logging_enabled { |
There was a problem hiding this comment.
Ideally this should use the conditional logging provided by the rust log / env_logger crate.
kitsonk
force-pushed
the
feat_lsp_debug
branch
3 times, most recently
from
9e436d3 to
08b4a79
Compare
ry
reviewed
May 7, 2021
cli/main.rs
Outdated
| unwrap_or_exit(tokio_util::run_basic(get_subcommand(flags))); | ||
| // when this flag is set to `true`, the process will log specific diagnostic | ||
| // debug information, | ||
| let lsp_debug_flag = Arc::new(AtomicBool::new(false)); |
There was a problem hiding this comment.
It's unfortunate that this lsp_debug_flag has leaked all the way to top-level of the program and many signatures have to be modified to pass it around.
What if you use lazy_static to have a global Arc<AtomicBool> in cli/logger.rs? Then cli/lsp/language_server.rs could reference that directly without having to pass it around like this. I think practically lsp_debug_flag is a global anyway.
There was a problem hiding this comment.
Yeah, that makes more sense. I will try that.
ry
added a commit
to ry/deno
that referenced
this pull request
May 12, 2021
This reverts commit 81f8585.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #10368
The lsp would respect a setting which will log all the marks and measures to stderr along with their arguments which can be used to investigate certain issues (as well as more easily generate test cases). This requires a client which can pass the configuration option (see: denoland/vscode_deno#406).