feat(cli/uninstall): Add uninstall command #12209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't find any instruction in the contributing guide on how to run the tests locally. 🤔 Any ideas ? |
crowlKats
reviewed
Sep 24, 2021
|
got the formatter to work by adding ""projectType": "openSource", in |
Make sure your git submodules are up to date:
No, the problem should be fixes once git submodules are up to date. |
dsherret
reviewed
Sep 24, 2021
dsherret
reviewed
Sep 24, 2021
crowlKats
reviewed
Sep 26, 2021
cli/flags.rs
Outdated
| @@ -1896,6 +1936,20 @@ fn install_parse(flags: &mut Flags, matches: &clap::ArgMatches) { | |||
| }); | |||
| } | |||
|
|
|||
| fn uninstall_parse(flags: &mut Flags, matches: &clap::ArgMatches) { | |||
| runtime_args_parse(flags, matches, true, true); | |||
There was a problem hiding this comment.
Suggested change
| runtime_args_parse(flags, matches, true, true); |
No need for runtime args parsing
dsherret
reviewed
Sep 26, 2021
dsherret
reviewed
Sep 26, 2021
| // ensure directory exists | ||
| if let Ok(metadata) = fs::metadata(&installation_dir) { | ||
| if !metadata.is_dir() { | ||
| return Err(generic_error("Installation path is not a directory")); |
There was a problem hiding this comment.
Another minor point: It might be useful to the user to include the resolved installation_dir path in this error message.
dsherret
force-pushed
the
scau_uninstall
branch
from
4954798 to
c1a8a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3139