feat(ext/fetch): support fetching local files #12545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Oct 26, 2021
kitsonk
force-pushed
the
kitsonk/issue11925
branch
from
96dd661 to
65a8b39
Compare
kitsonk
force-pushed
the
kitsonk/issue11925
branch
from
65a8b39 to
4883f66
Compare
kitsonk
force-pushed
the
kitsonk/issue11925
branch
from
e1eb831 to
bca32cb
Compare
kitsonk
force-pushed
the
kitsonk/issue11925
branch
from
6864787 to
5e9ac1a
Compare
piscisaureus
approved these changes
Nov 1, 2021
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
kitsonk
force-pushed
the
kitsonk/issue11925
branch
from
7746a4b to
43207a1
Compare
andreubotella
pushed a commit
to andreubotella/deno
that referenced
this pull request
Nov 26, 2021
Fetching of local files, added in denoland#12545, returns a response with no headers, including the `Content-Type` header. This currently makes it not work with the WebAssembly streaming APIs, which require the response to have a content type of `application/wasm`. Since the only way to obtain a `Response` object with a non-empty `url` field is via `fetch()`, this change changes the content type requirement to only apply to responses whose url has the `file:` scheme.
kitsonk
pushed a commit
that referenced
this pull request
Nov 26, 2021
…fetches (#12901) Fetching of local files, added in #12545, returns a response with no headers, including the `Content-Type` header. This currently makes it not work with the WebAssembly streaming APIs, which require the response to have a content type of `application/wasm`. Since the only way to obtain a `Response` object with a non-empty `url` field is via `fetch()`, this change changes the content type requirement to only apply to responses whose url has the `file:` scheme.
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11925
Closes #2150