feat: Add DENO_CACHED_ONLY env var as alternative to --cached-only #12769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding one-off environment variables feels kind of meh. IMO, a better solution is a single |
|
@ry is this something you want to land? What about other flags that could potentially benefit from having an env var mimic? |
|
|
||
| fn binary_env_var(name: &str) -> bool { | ||
| if let Ok(v) = env::var(name) { | ||
| if v == "1" { |
There was a problem hiding this comment.
You know my position on this, we should accept "true" and "false" for consistency.
This also works with NO_COLOR (evidence).
| false | ||
| } else { | ||
| eprintln!( | ||
| "env var '{}' has a bad value '{}'. Use '1' or '0'.", |
There was a problem hiding this comment.
+1 for showing feedback when the env var has an unsupported value.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12536