Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Improve reliability of deno test's op sanitizer with timers #12908

Merged
merged 1 commit into from
Nov 28, 2021
Merged

fix(test): Improve reliability of deno test's op sanitizer with timers #12908

merged 1 commit into from
Nov 28, 2021

Commits on Nov 27, 2021

  1. fix(test): Improve reliability of deno test's op sanitizer with timers 

    Although not easy to replicate in the wild, the `deno test` op sanitizer
can fail when there are intervals that started before a test runs, since
the op sanitizer can end up running in the time between the timer op for
an interval's run resolves and the op for the next run starts.

This change fixes that by adding a new macrotask callback that will run
after the timer macrotask queue has drained. This ensures that there is
a timer op if there are any timers which are unresolved by the time the
op sanitizer runs.
    Andreu Botella committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    237d44a View commit details
    Browse the repository at this point in the history