-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Wake up the runtime if there are ticks scheduled #12933
Conversation
See denoland#12771 and denoland#12814. Needed to reland denoland#12908, which was reverted in denoland#12929.
@bartlomieju @bnoordhuis PTAL. Reviewing with "hide whitespace" turned on helps. |
Restarted the CI because the test failure looks like a flake. Preserved here for posterity:
|
Closed and reopened because the license check was stuck in yellow. |
Oh no, I added that test 😓 EDIT: maybe you just got lucky and the randomly generated IV was actually the correct IV? If so... wow. You literally win the lottery today. Otherwise - no idea what is up with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
Co-authored-by: Andreu Botella <abb@randomunok.com>
See #12771 and #12814.
Needed to reland #12908, which was reverted in #12929.