Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Wake up the runtime if there are ticks scheduled #12933

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

andreubotella
Copy link
Contributor

See #12771 and #12814.

Needed to reland #12908, which was reverted in #12929.

@andreubotella
Copy link
Contributor Author

@bartlomieju @bnoordhuis PTAL. Reviewing with "hide whitespace" turned on helps.

core/runtime.rs Outdated Show resolved Hide resolved
@bnoordhuis
Copy link
Contributor

Restarted the CI because the test failure looks like a flake. Preserved here for posterity:

 testDecryptWithInvalidIntializationVector
AssertionError: Expected function to throw.
    at assertRejects (file:///home/runner/work/deno/deno/test_util/std/testing/asserts.ts:772:11)
    at async testDecryptWithInvalidIntializationVector (file:///home/runner/work/deno/deno/cli/tests/unit/webcrypto_test.ts:708:3)
    at async testStepSanitizer (deno:runtime/js/40_testing.js:162:7)
    at async asyncOpSanitizer (deno:runtime/js/40_testing.js:43:9)
    at async resourceSanitizer (deno:runtime/js/40_testing.js:113:7)
error: Test failed
    at async Object.exitSanitizer [as fn] (deno:runtime/js/40_testing.js:145:9)
    at async runTest (deno:runtime/js/40_testing.js:403:7)
    at async Object.runTests (deno:runtime/js/40_testing.js:514:22)

@andreubotella
Copy link
Contributor Author

Closed and reopened because the license check was stuck in yellow.

@lucacasonato
Copy link
Member

lucacasonato commented Nov 29, 2021

testDecryptWithInvalidIntializationVector
AssertionError: Expected function to throw.
at assertRejects (file:///home/runner/work/deno/deno/test_util/std/testing/asserts.ts:772:11)
at async testDecryptWithInvalidIntializationVector (file:///home/runner/work/deno/deno/cli/tests/unit/webcrypto_test.ts:708:3)
at async testStepSanitizer (deno:runtime/js/40_testing.js:162:7)
at async asyncOpSanitizer (deno:runtime/js/40_testing.js:43:9)

Oh no, I added that test 😓

EDIT: maybe you just got lucky and the randomly generated IV was actually the correct IV? If so... wow. You literally win the lottery today. Otherwise - no idea what is up with that.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@bartlomieju bartlomieju merged commit 48c5700 into denoland:main Nov 29, 2021
@andreubotella andreubotella deleted the next-tick-wakeup branch November 29, 2021 23:32
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Nov 30, 2021
bnoordhuis pushed a commit that referenced this pull request Nov 30, 2021
Co-authored-by: Andreu Botella <abb@randomunok.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants