-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext/crypto) - exportKey(pkcs8/spki/jwk) for ECDSA and ECDH #13104
Conversation
@lucacasonato - strange behaviour for WPT import_export ECDH SPKI P-256. The W3C spec says to export with
|
@seanwykes export |
@panva thanks .. backed out previous commit. |
@littledivy and @lucacasonato - I'd like your feedback on the lack of support for PKCS#8 SecretKey in p384 crate that currently affects both importKey and exportKey. I'm testing a strategy to solve this:
Any ideas on this? |
Sounds good. We do similar stuff with RSA key parameters. |
@littledivy export implemented here and import in #13154. The ec_key.rs code is the same, with only an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! ...regarding the addition WPT changes in unwrap/wrapKey, looks like they were false positive earlier? I guess we'll get a better idea in #13154
Towards #11690 - exportKey implemented for ECDSA and ECDH, extracted from #13013 with modifications
pkcs8 : curve P-256 and P-384
spki : curves P-256 and P-384
jwk :
Shares
ec_key.rs
with #13154.