Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/webstorage): make getOwnPropertyDescriptor with symbol return undefined #13348

Conversation

crowlKats
Copy link
Member

Closes #13347

@crowlKats
Copy link
Member Author

crowlKats commented Jan 12, 2022

probably should add a wpt for this

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yeah, I would raise an issue on the WPT tests for it.

@ah-yu
Copy link
Contributor

ah-yu commented Jan 12, 2022

has(target, p) {
return p === SymbolFor("Deno.customInspect") ||
(typeof target.getItem(p)) === "string";
},

It seems Symbol('foo') in localStorage would throw same error

@bartlomieju
Copy link
Member

@crowlKats can this be landed for 1.19?

@crowlKats
Copy link
Member Author

crowlKats commented Feb 16, 2022

@bartlomieju I need to look into this again; functionality wise its correct, but no tests currently so i'd like to hold off for a later release

@stale
Copy link

stale bot commented May 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 25, 2022
@stale stale bot closed this Jun 4, 2022
@lucacasonato lucacasonato reopened this Sep 18, 2024
Signed-off-by: Luca Casonato <hello@lcas.dev>
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crowlKats can you add a test?

@crowlKats crowlKats merged commit 9a92603 into denoland:main Oct 7, 2024
17 checks passed
@crowlKats crowlKats deleted the localstorage_getOwnPropertyDescriptor_symbol branch October 7, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw an error when accessing the value of symbol property on localStorage object
5 participants