-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(emit): eliminate multiple cache files getting out of sync and fix racy emit #13462
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Any updates on this? I'm hoping this will fix #12126 |
Potentially fixes #14206, as well. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Closing because this is really out of date. I added an |
Supersedes #13303.
Closes #13302
WIP though basically done. I could do way more cleanup and have a better design, but wanted to make the minimal changes possible.
TODO:
get_emit_data
verify the source. Maybe an API change would be good to force this (ex.ProcState
'sSourceMapGetter
impl right now retrieves the source map from the cache, but doesn't do any source checks on it). I think though it probably needs more rework in that area and I will have to read the code more.cover_files
does not verify the retrieved emit text is for the source