-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cancel old in-progress CI workflows #13811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not do this on main? On main we want CI for every commit so we get all the canary releases.
@lucacasonato |
Yup, This won't affect |
One note: this does make committing multiple commits to find flaky tests more difficult. |
Yeah basically in such case we'll need to push empty commit after the previous one finished. Let's see how it works, but I'm skeptical |
CI will run only on the latest commit in a PR. Saves energy 🌲
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
Idea from nodejs/node#42017