chore: improve build times for ext/ changes
#13927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, did you verify that snapshots are properly rebuilt when JS code changes in any of the |
Yup |
bartlomieju
requested changes
Mar 13, 2022
| @@ -78,22 +78,33 @@ fn create_compiler_snapshot( | |||
| ) { | |||
| // libs that are being provided by op crates. | |||
| let mut op_crate_libs = HashMap::new(); | |||
| op_crate_libs.insert("deno.console", deno_console::get_declaration()); | |||
| op_crate_libs.insert("deno.url", deno_url::get_declaration()); | |||
| op_crate_libs.insert("deno.web", deno_web::get_declaration()); | |||
There was a problem hiding this comment.
It seems these get_declaration methods could now be removed
bartlomieju
approved these changes
Mar 13, 2022
ry
added a commit
to ry/deno
that referenced
this pull request
Mar 16, 2022
This reverts commit 4e3ed37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent for a trivial change in
ext/crypto:main:This PR:
Skips running
deno (build.rs)when it's not needed by removing extension crates as its build dependency.